Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] drm/panfrost: missing moduleparam.h include for module_param_named --
commit 773e4af10fafabff3b1003f157c629dac2d4ca7d Author: Adrián Larumbe <[email protected]> drm/panfrost: Move lock and modparam initialisations into their subsystems This commit moves subsystem-specific lock and list initializations, as well as module parameters, out of panfrost_drv.c and into their respective subsystems to unclutter the device init function. > diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.c > b/drivers/gpu/drm/panfrost/panfrost_gem.c > index f39c0f50ed4ff..383ac8cd56456 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_gem.c > +++ b/drivers/gpu/drm/panfrost/panfrost_gem.c > @@ -11,20 +11,27 @@ > #include <drm/panfrost_drm.h> > #include <drm/drm_print.h> > #include "panfrost_device.h" > -#include "panfrost_drv.h" > #include "panfrost_gem.h" > #include "panfrost_mmu.h" > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +static bool panfrost_transparent_hugepage = true; > +module_param_named(transparent_hugepage, panfrost_transparent_hugepage, > bool, 0400); > +MODULE_PARM_DESC(transparent_hugepage, "Use a dedicated tmpfs mount point > with Transparent Hugepage enabled (true = default)"); [Severity: Low] Does this file need to include <linux/moduleparam.h> for these macros? Since module_param_named() and MODULE_PARM_DESC() were moved into panfrost_gem.c, and the panfrost_drv.h include was removed, omitting <linux/moduleparam.h> (or <linux/module.h>) can cause a build failure when compiling this file. -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
