Hello, Konrad Rzeszutek Wilk. > -----Original Message----- > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk at oracle.com] > Sent: Thursday, September 22, 2011 3:53 AM > To: Inki Dae > Cc: airlied at linux.ie; dri-devel at lists.freedesktop.org; > sw0312.kim at samsung.com; kyungmin.park at samsung.com; linux-arm- > kernel at lists.infradead.org > Subject: Re: [PATCH v4] DRM: add DRM Driver for Samsung SoC EXYNOS4210. > > > > > > > + DRM_ERROR("desired size is bigger then real > > size.\n"); > > > > > > > > > > So .. you can't continue by just using the real size instead? > > > > > > > > > > > > > I am afraid I don't understand what you mean but I think that > condition > > > is > > > > fine. size is a vm area to user-desired size and you could request > > > mapping > > > > as specific size. so it just check user-requested virtual space > region > > > it > > > > bigger than allocated physical memory region to be mapped. if there > is > > > my > > > > missing points, I would be happy to you give me your comments. thank > > you. > > > > > > I meant that you return -EINVAL. But I am wondering if it would be > > > possible > > > to just continue on, but ignore what the user specified. > > > > > > I think the issue here is that you are outputing the DRM_ERROR and > > > I am not sure if it is that neccessary. Perhaps DRM_DEBUG, but > DRM_ERROR > > > just seems a bit.. heavy handed. > > > > > > > I thought this condition would be critical issue as user application > should > > be terminated. is your wondering if user application could go ahead > after > > mmap failed? this is just my view so I would be happy you to give me > your > > advice. Thank you. > > I think terminating the appliaction is the right thing. But the DRM_ERROR > is not neccessary.
I understood. I will remove DRM_ERROR or use DRM_DEBUG instead. thank you.
