Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] drm: missing forward declaration for struct drm_connector_state --
commit a718c67acdeea45641698c75babcb127ecc60810 Author: Maxime Ripard <[email protected]> drm/atomic: Export drm_atomic_*_print_state This commit exports four DRM atomic print state functions by removing their static qualifiers and declaring them in drm_internal.h. This allows the SRO infrastructure to call them for debugging purposes. [ ... ] > diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h > index f893b1e3a596e..91ce23f69ec48 100644 > --- a/drivers/gpu/drm/drm_internal.h > +++ b/drivers/gpu/drm/drm_internal.h > @@ -40,14 +40,26 @@ struct dma_buf; > struct iosys_map; > struct drm_connector; > struct drm_crtc; > +struct drm_crtc_state; > struct drm_framebuffer; > struct drm_gem_object; > struct drm_master; > struct drm_minor; > +struct drm_plane_state; > struct drm_prime_file_private; > struct drm_printer; > +struct drm_private_state; [Severity: Low] Does this file also need a forward declaration for struct drm_connector_state? Without it, the struct is scoped only to the prototype below, which might cause build warnings for any C file that includes this header without previously declaring or defining it. > struct drm_vblank_crtc; > > +/* drm_atomic.c */ > +void drm_atomic_plane_print_state(struct drm_printer *p, > + const struct drm_plane_state *state); > +void drm_atomic_crtc_print_state(struct drm_printer *p, > + const struct drm_crtc_state *state); > +void drm_atomic_connector_print_state(struct drm_printer *p, > + const struct drm_connector_state *state); > +void drm_atomic_private_obj_print_state(struct drm_printer *p, > + const struct drm_private_state *state); -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=5
