Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] dt-bindings: missing minItems: 4 for nvidia,gm20b makes fuse clock optional --
commit ce5f108aa60b7d673901db80f95bfdff4aaaa9a2 Author: Sasha Levin <[email protected]> dt-bindings: gpu: nvidia,gk20a: Require the fuse clock This commit modifies the nvidia,gk20a binding to make the fuse clock required for all GPUs in this family. It specifies the exact order of the clocks depending on the GPU compatible string. > diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml > b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml > index 4d856a8b674c5..af0ada6e02557 100644 > --- a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml > +++ b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml > @@ -86,6 +80,39 @@ required: > - reset-names > > allOf: > + - if: > + properties: > + compatible: > + contains: > + const: nvidia,gm20b > + then: > + properties: > + clocks: > + items: > + - description: GPU clock > + - description: Power clock > + - description: Reference clock > + - description: Fuse clock > + > + clock-names: > + items: > + - const: gpu > + - const: pwr > + - const: ref > + - const: fuse [Severity: Medium] The commit message states the intent is to make the fuse clock required for all of them, but will this schema actually enforce it for nvidia,gm20b? Because the global schema defines `minItems: 3` and `maxItems: 4` for `clocks` and `clock-names`, the array validation in this `allOf` conditional for `nvidia,gm20b` inherits `minItems: 3`. A device tree with only 3 clocks (gpu, pwr, ref) will successfully validate against the first 3 items in the list, making the `fuse` clock implicitly optional. Should `minItems: 4` be explicitly added to both `clocks` and `clock-names` in this `then` block to ensure the fuse clock is properly enforced? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
