Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] drm: build failure from removing __drm_atomic_helper_connector_reset() --
commit ec915c4081ebec2a7cd348c5409dae402f04f843 Author: Maxime Ripard <[email protected]> drm/connector: Remove __drm_atomic_helper_connector_reset() This commit removes the __drm_atomic_helper_connector_reset() helper function, its prototype, and its documentation reference after converting connector reset hooks to atomic_create_state. > diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c > b/drivers/gpu/drm/drm_atomic_state_helper.c > index 5efda28bb2b07..267f443306295 100644 > --- a/drivers/gpu/drm/drm_atomic_state_helper.c > +++ b/drivers/gpu/drm/drm_atomic_state_helper.c > @@ -412,29 +412,6 @@ __drm_atomic_helper_connector_state_init(struct > drm_connector_state *conn_state, > } > EXPORT_SYMBOL(__drm_atomic_helper_connector_state_init); > > -/** > - * __drm_atomic_helper_connector_reset - reset state on connector > - * @connector: drm connector > - * @conn_state: connector state to assign > - * > - * Initializes the newly allocated @conn_state and assigns it to > - * the &drm_connector->state pointer of @connector, usually required when > - * initializing the drivers or when called from the > &drm_connector_funcs.reset > - * hook. > - * > - * This is useful for drivers that subclass the connector state. > - */ > -void > -__drm_atomic_helper_connector_reset(struct drm_connector *connector, > - struct drm_connector_state *conn_state) > -{ > - if (conn_state) > - __drm_atomic_helper_connector_state_init(conn_state, connector); > - > - connector->state = conn_state; > -} > -EXPORT_SYMBOL(__drm_atomic_helper_connector_reset); [Severity: Medium] Does removing __drm_atomic_helper_connector_reset() in drivers/gpu/drm/drm_atomic_state_helper.c and its prototype in include/drm/drm_atomic_state_helper.h cause a build regression when CONFIG_DRM_MALI_DISPLAY, CONFIG_DRM_RCAR_WRITEBACK (under CONFIG_DRM_RCAR_DU), or CONFIG_DRM_VMWGFX is enabled? The commit message states that all drivers implementing the connector reset hook using __drm_atomic_helper_connector_reset() have been converted to atomic_create_state, but three in-tree drivers still call __drm_atomic_helper_connector_reset() from their drm_connector_funcs.reset callbacks. In drivers/gpu/drm/arm/malidp_mw.c:malidp_mw_connector_reset(): if (mw_state) __drm_atomic_helper_connector_reset(connector, &mw_state->base); In drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c:rcar_du_wb_conn_reset(): state = kzalloc_obj(*state); if (state == NULL) return; __drm_atomic_helper_connector_reset(connector, &state->state); In drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:vmw_du_connector_reset(): vcs = kzalloc_obj(*vcs); if (!vcs) { DRM_ERROR("Cannot allocate vmw_connector_state\n"); return; } __drm_atomic_helper_connector_reset(connector, &vcs->base); None of these three drivers are converted in the subsequent patch in the series, commit 86331e69eb719274bf362ebe2870d757866546bb ("drm/connector: Remove reset"). Should malidp_mw_connector_reset(), rcar_du_wb_conn_reset(), and vmw_du_connector_reset() be converted to atomic_create_state before __drm_atomic_helper_connector_reset() is removed so that building those drivers does not fail with implicit function declaration and undefined symbol errors? [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/20261022-drm-no-more-connector-reset-v2-0-0b7e4e85b...@kernel.org?part=58
