Hi David, On Wed Oct 7, 2026 at 4:10 PM CEST, David Francis wrote: > Make the following changes to CHANGE_HANDLE > - reject new_handle = old_handle with EINVAL > - idr_preload before idr_alloc > - reject new_handle = 0 with EINVAL > > See also the igt patch > tests/intel: Add edge case and race condition tests for GEM_CHANGE_HANDLE > on igt-dev > > v2: new_handle = old_handle is EINVAL > > cc: Tvrtko Ursulin <[email protected]> > cc: Christian Koenig <[email protected]> > cc: Simona Vetter <[email protected]> > Signed-off-by: David Francis <[email protected]> > --- I had a brief look at this series and it looks pretty good to me. I would improve the commit messages so they describe not only what was done, but also why. From my side, I ran the new tests on the try bot, and they all pass.
https://patchwork.freedesktop.org/series/177021/#rev1 (re run doesn't pick up the new tests for some reason, soplease look at rev1) New tests have been introduced between CI_DRM_19403_full and Trybot_177021v1_full: New IGT tests (11) igt@gem_change_handle@change_prime: Statuses : 6 pass(s) Exec time: [0.01, 0.04] s igt@gem_change_handle@invalid_handle: Statuses : 6 pass(s) Exec time: [0.01, 0.05] s igt@gem_change_handle@new_handle_equals_old_handle: Statuses : 4 pass(s) Exec time: [0.01, 0.03] s igt@gem_change_handle@new_handle_exceeds_int_max: Statuses : 7 pass(s) Exec time: [0.01, 0.04] s igt@gem_change_handle@new_handle_taken: Statuses : 6 pass(s) Exec time: [0.01, 0.03] s igt@gem_change_handle@new_handle_zero: Statuses : 6 pass(s) Exec time: [0.01, 0.04] s igt@gem_change_handle@race_change_change: Statuses : 6 pass(s) Exec time: [1.01, 1.04] s igt@gem_change_handle@race_change_create_close: Statuses : 7 pass(s) Exec time: [1.01, 1.04] s igt@gem_change_handle@race_change_export_import: Statuses : 6 pass(s) Exec time: [1.01, 1.03] s igt@gem_change_handle@sanity: Statuses : 6 pass(s) Exec time: [0.01, 0.03] s igt@kms_cursor_crc@cursor-onscreen-64x64@pipe-c-hdmi-a-2: Statuses : 1 pass(s) Exec time: [2.23] s -- Best regards, Sebastian
