Three lifetime fixes for problems Sashiko, the AI review bot, pointed
out while reviewing a pxafb cleanup [1].  Removal leaves the cpufreq
notifier registered on freed memory and the smart-panel thread running,
and the interrupt handler can signal completions before probe has
initialised them.

v2: v1 went out before it was ready, as separate patches without my
Signed-off-by or Fixes tags, and the completion patch depended on the
others without saying so; sorry about that.  This version adds the tags,
sends the patches as a series, and says in each commit message what goes
wrong and how it is reached.  The notifier fix is now a patch of its
own, and the smart-panel patch stops the thread after the controller is
disabled and no longer changes the thread's freezer loop.  Patch 3 is
unchanged.

I have dropped "fbdev: pxafb: preserve IRQ probe errors".  On the
in-tree PXA platforms the interrupt controller is registered from
init_IRQ(), before any driver probes, so I could not find a way for
platform_get_irq() to return -EPROBE_DEFER here, and the patch changed
nothing users would see.

[1] https://lore.kernel.org/all/[email protected]/

v1 of patches 1 and 2 ("stop smart-panel thread and notifier"):
https://lore.kernel.org/all/[email protected]/
v1 of patch 3:
https://lore.kernel.org/all/[email protected]/
v1 of the dropped patch:
https://lore.kernel.org/all/[email protected]/

Thanks,
Matthias

Matthias Goergens (3):
  fbdev: pxafb: unregister cpufreq notifier on removal
  fbdev: pxafb: stop the smart-panel thread
  fbdev: pxafb: initialize IRQ completions before requesting IRQ

 drivers/video/fbdev/pxafb.c | 46 +++++++++++++++++++++++++++++--------
 1 file changed, 36 insertions(+), 10 deletions(-)


base-commit: d89e1d186ec9271bf78e62771779e9fc03bf0fc3
-- 
2.56.0

Reply via email to