Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [High] drm/ingenic: use-after-free in ingenic_drm_bind() from devm/drmm mismatch - [Low] drm/ingenic: missing devm_drm_bridge_add() in ingenic_drm_bind() --
commit b0cc78f8ec81445f2abbfeb18a785a51d40b8824 Author: Maxime Ripard <[email protected]> drm/ingenic: Convert to devm_drm_bridge_alloc() This commit converts struct ingenic_drm_bridge allocation in ingenic_drm_bind() from drmm_encoder_alloc() to devm_drm_bridge_alloc() paired with drmm_encoder_init(). > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index 63198fd594984..8cad8dcfae609 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -1303,20 +1303,27 @@ static int ingenic_drm_bind(struct device *dev, bool > has_components) > drm_panel_put(panel); > } > > - ib = drmm_encoder_alloc(drm, struct ingenic_drm_bridge, encoder, > - NULL, DRM_MODE_ENCODER_DPI, NULL); > + ib = devm_drm_bridge_alloc(dev, struct ingenic_drm_bridge, > + bridge, &ingenic_drm_bridge_funcs); > if (IS_ERR(ib)) { > ret = PTR_ERR(ib); > - dev_err(dev, "Failed to init encoder: %d\n", ret); > + dev_err(dev, "Failed to allocate bridge: %d\n", ret); > goto err_drvdata; > } > > encoder = &ib->encoder; > + > + ret = drmm_encoder_init(drm, encoder, NULL, > + DRM_MODE_ENCODER_DPI, NULL); > + if (ret) { > + dev_err(dev, "Failed to init encoder: %d\n", ret); > + goto err_drvdata; > + } [Severity: High] Can mixing devm_drm_bridge_alloc() and drmm_encoder_init() on the same struct ingenic_drm_bridge cause a use-after-free of ib->encoder during teardown? ingenic_drm_bind() allocates drm via devm_drm_dev_alloc() before calling devm_drm_bridge_alloc(), so devres runs drm_bridge_put_void(&ib->bridge) before devm_drm_dev_init_release() runs drm_managed_release(). On unbind, drm_bridge_put_void() drops the devm reference on ib->bridge, leaving only the reference taken by drm_bridge_attach(). When drmm_encoder_alloc_release() then calls drm_encoder_cleanup(&ib->encoder), detaching ib->bridge drops its last reference and __drm_bridge_free() frees the entire struct ingenic_drm_bridge container while drm_encoder_cleanup() is still accessing encoder: drivers/gpu/drm/drm_encoder.c:drm_encoder_cleanup() { ... list_for_each_entry_safe(bridge, next, &tmplist, chain_node) drm_bridge_detach(bridge); drm_mode_object_unregister(dev, &encoder->base); kfree(encoder->name); list_del(&encoder->head); dev->mode_config.num_encoder--; mutex_destroy(&encoder->bridge_chain_mutex); memset(encoder, 0, sizeof(*encoder)); } If drm_bridge_attach() fails earlier during bind (for example with -EPROBE_DEFER), drm_bridge_put_void() frees ib before drm_managed_release() even enters drm_encoder_cleanup(). > + > encoder->possible_crtcs = drm_crtc_mask(&priv->crtc); > > drm_encoder_helper_add(encoder, > &ingenic_drm_encoder_helper_funcs); > > - ib->bridge.funcs = &ingenic_drm_bridge_funcs; > ib->next_bridge = bridge; > > ret = drm_bridge_attach(encoder, &ib->bridge, NULL, [Severity: Low] Does attaching &ib->bridge without calling devm_drm_bridge_add() first trigger a warning in drm_bridge_attach()? Previously drmm_encoder_alloc() zero-initialized ib->bridge.list, so list_empty(&bridge->list) was false. __devm_drm_bridge_alloc() initializes bridge->list with INIT_LIST_HEAD(), causing drm_bridge_attach() to hit DRM_WARN("Missing drm_bridge_add() before attach\n") on every probe. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
