You need a commit description.

Am 26.10.26 um 08:19 schrieb Karthik Sarvan:
Signed-off-by: Karthik Sarvan <[email protected]>
---
  drivers/gpu/drm/vkms/vkms_drv.c | 8 ++------
  1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 5a640b531..10337889b 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -146,12 +146,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
        dev->mode_config.max_height = YRES_MAX;
        dev->mode_config.cursor_width = 512;
        dev->mode_config.cursor_height = 512;
-       /*
-        * FIXME: There's a confusion between bpp and depth between this and
-        * fbdev helpers. We have to go with 0, meaning "pick the default",
-        * which is XRGB8888 in all cases.
-        */
-       dev->mode_config.preferred_depth = 0;
+       /* XRGB8888 has 24 bits of color data stored in 32 bits per pixel. */
+       dev->mode_config.preferred_depth = 24;
        dev->mode_config.helper_private = &vkms_mode_config_helpers;
return vkms_output_init(vkmsdev);

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)


Reply via email to