send_bo_list_to_device() does not validate if the BOs the user passes
through DRM_QAIC_EXECUTE_BO and DRM_QAIC_PARTIAL_EXECUTE_BO IOCTLs are
attached to the DBC provided. This allows the user to slice and attach
BOs to one DBC, and execute them over another DBC.

The same case applies for qaic_wait_bo_ioctl() as well as it neither
checks if the BO is sliced, nor if it attached to the passed DBC.

Fixes: ff13be830333 ("accel/qaic: Add datapath")
Signed-off-by: Youssef Samir <[email protected]>
---
 drivers/accel/qaic/qaic_data.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/accel/qaic/qaic_data.c b/drivers/accel/qaic/qaic_data.c
index ee35e13091b3..be3ceb8c51a0 100644
--- a/drivers/accel/qaic/qaic_data.c
+++ b/drivers/accel/qaic/qaic_data.c
@@ -1256,6 +1256,11 @@ static int send_bo_list_to_device(struct qaic_device 
*qdev, struct drm_file *fil
                        goto unlock_bo;
                }
 
+               if (bo->dbc->id != dbc->id) {
+                       ret = -EINVAL;
+                       goto unlock_bo;
+               }
+
                if (is_partial && pexec[i].resize > bo->base.size) {
                        ret = -EINVAL;
                        goto unlock_bo;
@@ -1769,6 +1774,17 @@ int qaic_wait_bo_ioctl(struct drm_device *dev, void 
*data, struct drm_file *file
        }
 
        bo = to_qaic_bo(obj);
+
+       if (!bo->sliced) {
+               ret = -EINVAL;
+               goto put_obj;
+       }
+
+       if (bo->dbc->id != dbc->id) {
+               ret = -EINVAL;
+               goto put_obj;
+       }
+
        timeout = args->timeout ? args->timeout : wait_exec_default_timeout_ms;
        timeout = msecs_to_jiffies(timeout);
        ret = wait_for_completion_interruptible_timeout(&bo->xfer_done, 
timeout);
-- 
2.43.0

Reply via email to