From: David Heidelberg <[email protected]> S6E3HA8 is the DDIC, while the panel used on the Samsung Galaxy S9 is the Samsung AMB577PX01. Introduce a compatible reflecting that, adjust the example, and deprecate the DDIC-only samsung,s6e3ha8 compatible.
We're going to introduce another panel with different sequence, so keep calling original panel sequence just by the DDIC name is confusing. While we at it, we can cleanly fix reversed GPIO polarity. Update the polarity to better match newly introduced compatibles with fixed logic. Signed-off-by: David Heidelberg <[email protected]> --- .../bindings/display/panel/samsung,s6e3ha8.yaml | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml index 00ce5a4e1c6be..ca250b1b91712 100644 --- a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml @@ -1,28 +1,35 @@ # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 --- $id: http://devicetree.org/schemas/display/panel/samsung,s6e3ha8.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: Samsung s6e3ha8 AMOLED DSI panel -description: The s6e3ha8 is a 1440x2960 DPI display panel from Samsung Mobile - Displays (SMD). +description: | + The s6e3ha8 is a display driver IC used in 1440x2960 AMOLED panels from + Samsung Mobile Displays (SMD). + + Known panels: + - AMB577PX01, 5.77", Samsung Galaxy S9 (samsung,s6e3ha8-amb577px01) maintainers: - Dzmitry Sankouski <[email protected]> allOf: - $ref: panel-common.yaml# properties: compatible: - const: samsung,s6e3ha8 + oneOf: + - const: samsung,s6e3ha8-amb577px01 + - const: samsung,s6e3ha8 + deprecated: true reg: maxItems: 1 vdd3-supply: description: VDD regulator vci-supply: @@ -44,23 +51,23 @@ examples: - | #include <dt-bindings/gpio/gpio.h> dsi { #address-cells = <1>; #size-cells = <0>; panel@0 { - compatible = "samsung,s6e3ha8"; + compatible = "samsung,s6e3ha8-amb577px01"; reg = <0>; vci-supply = <&s2dos05_ldo4>; vddr-supply = <&s2dos05_buck1>; vdd3-supply = <&s2dos05_ldo1>; te-gpios = <&tlmm 10 GPIO_ACTIVE_HIGH>; - reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; + reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>; pinctrl-0 = <&sde_dsi_active &sde_te_active_sleep>; pinctrl-1 = <&sde_dsi_suspend &sde_te_active_sleep>; pinctrl-names = "default", "sleep"; port { panel_in: endpoint { remote-endpoint = <&mdss_dsi0_out>; }; -- 2.55.0
