This series is NOT meant to be merged yet. It puts the board data of the rear camera of the ASUS ROG Flow Z13 (GZ302EA) into patches, so the sensor can be enabled once the ISP firmware supports it. In the v6 thread of the ISP4 driver [1], Mario noted that OMNI13B1 would need a new amdgpu entry and the matching GPIO tables; this is that data, plus the board configuration and a small sensor-driver change.
Caspar Adriani already posted an OMNI13B1 amdgpu/amd_isp4 patch in his RFC [3] and dropped it after Pratap's reply [2]; credit for the first posting goes to him. This series covers the sensor reset GPIO, the 24 MHz clock and four lanes in the graph, and an I2C ID table for ov13b10, and lists where every value comes from (below). Why not for merging: with isp_4_1_1.bin from linux-firmware, SET_STREAM_CONFIG fails with error 6 (UNSUPPORTED_SENSOR) for this sensor, as Pratap explained in [2]. Merging patch 3 would make every GZ302 show a camera that cannot stream. The stock linux-firmware image does not start this sensor; on my machine the camera runs with ISP firmware and sensor setup data from my own Windows driver installation, read from the Windows partition of that machine. I do not redistribute any of it. The values and where they come from: - ACPI _HID OMNI13B1: \_SB.CAMB in an SSDT (confirmed). - I2C address 0x10: the sensor answers there; the _DSM returns the same value (confirmed). - Sensor clock 24 MHz: the rate declared for the OV05C10 platform (assumed). - Four CSI-2 lanes at 560 MHz: the ov13b10 full-resolution mode (assumed). - Sensor reset, amdisp-pinctrl GPIO 0, active low: tested on the GZ302 (confirmed). - enable_isp, AMDI0030:00 pin 85: copied from OMNI5C10 (unconfirmed). The capture driver needs it to probe, no ACPI device claims the pin, and the ISP also boots with it left undriven. Bin, Pratap: the firmware sets up the sensor clock and link, so could you confirm the clock rate, the link frequency and whether pin 85 is needed on this board? Sensor model: as Bin and Pratap explained, on Linux the ISP firmware controls the sensor, and the reference ov05c10 sensor is not bound by a host driver. Patches 2 and 3 fit that model. Patch 1 and the 24 MHz dependency below only matter if a host sensor driver is used, which is how my out-of-tree setup starts the sensor. Which model will the sensor-agnostic driver use for OV13B10? If it is firmware-only, patch 1 can be dropped. Dependencies before this can be merged: - ISP firmware that supports the OV13B10 on this platform. - With a host sensor driver only: 24 MHz support in ov13b10, which accepts only a 19.2 MHz external clock today. - Patch 3 needs patch 2: the ISP setup in amdgpu uses the software node that amd_isp4 attaches to the ACPI device, as for OMNI5C10. Patch 2 copies the software-node graph of the OV05C10 entry. If a shared graph builder is preferred, I am happy to rework it that way. Patches 1 and 2 have no user-visible effect on their own; patch 3 is the one that makes amdgpu create the ISP for this board. Testing: built with W=1 (clang) on next-20261026. Not runtime-tested in this form. The same graph, I2C address and reset GPIO work out of tree on the GZ302: the board configuration in a patched amd_isp4 module, the reset GPIO registered from there, and an ACPI override that lets the stock amdgpu find the sensor. There the clock is still declared as 19.2 MHz and the sensor driver is adapted to 24 MHz. That out-of-tree code is in a repository I can share on request. I can test patches and firmware on the GZ302 at any time. Related: two isp4 driver fixes found on this machine were sent to linux-media separately [4] and have been reviewed by Bin and Pratap, and the GZ302 bring-up is discussed in [3]. AI use: Claude (Claude Code) helped me write these patches and the changelogs from the out-of-tree code, and run the checks. I reviewed everything. [1] https://lore.kernel.org/all/[email protected]/ [2] https://lore.kernel.org/all/[email protected]/ [3] https://lore.kernel.org/all/lWYl1YJwDSh-q2Ew2f8b0BweQ4V-SUnPMSMurU5gT1LkqVdrmWFunj0sSgjC7m66bORBAD_jRCFTt1_ZOkotOMukY46rI4ayYbIfPQq4E9U=@proton.me/ [4] https://lore.kernel.org/all/[email protected]/ Regards, Seifelden Seifelden Abdelmonem (3): media: i2c: ov13b10: add an I2C device ID table platform/x86: amd_isp4: add the OV13B10 (OMNI13B1) board configuration drm/amdgpu: add the OMNI13B1 (OV13B10) ISP sensor drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 1 + drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c | 13 ++- drivers/media/i2c/ov13b10.c | 7 ++ drivers/platform/x86/amd/amd_isp4.c | 127 +++++++++++++++++++++++ 4 files changed, 147 insertions(+), 1 deletion(-) base-commit: f1ac44c32cba88ad65dcecd4a279661d14e93651 -- 2.56.0
