Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/drm_ras: missing Fixes tag for drm_ras_nl_list_nodes_dumpit() init fix --
commit 9457b6b1f3039e9c4f6cd72731d15ae7fe2a5454 Author: Zack McKevitt <[email protected]> > drm/drm_ras: Remove admin-perm flag from list-nodes operation > > Drivers may want to avoid requiring CAP_NET_ADMIN for subsequent > drm-ras operations. However, userspace must still be able to access > the list of RAS nodes to determine the node IDs. So, drop the > CAP_NET_ADMIN requirement for dumping RAS nodes so that drivers > with different permission requirements are still able to use the > interface. > > Additionally, initialize the return value to zero in > drm_ras_nl_list_nodes_dumpit to avoid leaking uninitialized kernel > memory (especially now that this function no longer requires admin > permissions). > > This prepares the interface to be used for telemetry by the qaic > driver. > > Reviewed-by: Rodrigo Vivi <[email protected]> > Reviewed-by: Jeff Hugo <[email protected]> > Signed-off-by: Zack McKevitt <[email protected]> [Severity: Low] Since this also fixes an uninitialized return value in drm_ras_nl_list_nodes_dumpit() when xa_for_each_start() runs zero iterations, should it include: Fixes: c36218dc49f5 ("drm/ras: Introduce the DRM RAS infrastructure over generic netlink") -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
