Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] drm/panthor: adev->pc[i] left set on partition_ensure_reset() failure --
commit 872e2f2e631e5b4428bb12ac09aefb750b611c43 Author: Karunika Choo <[email protected]> drm/panthor: Reset partitions before starting arbitration This commit ensures each partition is brought into the RESET state with interrupts masked during partition control initialization before starting arbitration. > diff --git a/drivers/gpu/drm/panthor/arbitration/panthor_partition_control.c > b/drivers/gpu/drm/panthor/arbitration/panthor_partition_control.c > index 3b472403f49d1..2c0f8dc0b3bfb 100644 > --- a/drivers/gpu/drm/panthor/arbitration/panthor_partition_control.c > +++ b/drivers/gpu/drm/panthor/arbitration/panthor_partition_control.c [ ... ] > @@ -429,6 +479,10 @@ static int partition_control_init(struct > panthor_arbitration *adev, int i) > > adev->pc[i] = pc; > > + ret = partition_ensure_reset(pc); > + if (ret) > + return ret; [Severity: Medium] Should adev->pc[i] be assigned only after partition_ensure_reset() succeeds? When partition_ensure_reset() fails, panthor_arbitration_probe() unwinds via panthor_partition_control_term(), which iterates over non-NULL adev->pc[i] entries and runs window_close() and partition_state_wait() on the partition that just failed reset recovery, triggering WARN_ON() and an extra 5-second timeout. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=28
