Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] backlight: ktd3137: use named initializer in ktd3137_ids
--

commit 8835810206d0f5ccda9a816dd64ce8c1128ef9b3
Author: Roman Vivchar <[email protected]>

backlight: add ktd3137 support

This commit adds an I2C backlight driver for the Kinetic KTD3137 display
backlight IC.

> diff --git a/drivers/video/backlight/ktd3137.c 
> b/drivers/video/backlight/ktd3137.c
> new file mode 100644
> index 0000000000000..1595aefd46e6c
> --- /dev/null
> +++ b/drivers/video/backlight/ktd3137.c
> @@ -0,0 +1,258 @@

[ ... ]

> +static const struct i2c_device_id ktd3137_ids[] = {
> +     { "ktd3137" },
> +     { }
> +};

[Severity: Low]
This isn't a bug, but new struct i2c_device_id entries should use named
initializers ({ .name = "ktd3137" }).

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=2

Reply via email to