Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: display: panel: ilitek,ili9806e: port made optional
  for SPI panel
--

commit 2dd7afd9762ebccda9424fc16917d18216458223
Author: Krzysztof Kozlowski <[email protected]>

dt-bindings: display: panel: Make DSI panels port optional

This commit removes the port property from the required list in 39 DSI
panel Device Tree bindings so that panels placed directly under a DSI bus
node do not have to specify an OF graph port.

> diff --git 
> a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml 
> b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
> index 2080d9e0ffac4..9a2602ddd9060 100644
> --- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
> @@ -33,7 +33,6 @@ required:
>    - vdd-supply
>    - reset-gpios
>    - backlight
> -  - port
>  
>  if:
>    properties:

[Severity: Low]
Should port remain required in the conditional then branch for
rocktech,rk050hr345-ct106a?

While densitron,dmt028vghmcmi-1d and ortustech,com35h3p70ulc are MIPI-DSI
panels, rocktech,rk050hr345-ct106a is an SPI-controlled DPI/RGB panel
(driven by panel-ilitek-ili9806e-spi.c with DRM_MODE_CONNECTOR_DPI).
Because it sits under an SPI controller node, the RGB display controller
still needs the OF graph port to link to the panel.

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=1

Reply via email to