Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [High] arm64: dts: qcom: Signed-off-by uses handle erebion instead of real name - [Low] arm64: dts: qcom: sm6350-lena: inconsistent Sony firmware-name path --
commit 242b8f170866c87626f6fca5aa977fc4b21bc731 Author: erebion <erebion@[email protected]> > arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP, IPA & MPSS > > Enable the ADSP, CDSP, IPA and MPSS (Modem) nodes for the Xperia 10 III. > > Signed-off-by: erebion <[email protected]> [Severity: High] The Author and Signed-off-by lines use a handle ("erebion") instead of a real human name, which does not meet the Developer's Certificate of Origin requirements in Documentation/process/submitting-patches.rst. > diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts > b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts > index a393b7533ccbf..4066de20ea23a 100644 > --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts > +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts > @@ -68,6 +68,12 @@ memory@fe901000 { > }; > }; > > +&adsp { > + firmware-name = "qcom/sm6350/Sony/pdx213/adsp.mbn"; > + > + status = "okay"; > +}; > + > &apps_rsc { > regulators-0 { > compatible = "qcom,pm6350-rpmh-regulators"; > @@ -291,6 +297,12 @@ pm6150l_bob: bob { > }; > }; > > +&cdsp { > + firmware-name = "qcom/sm6350/Sony/pdx213/cdsp.mbn"; > + > + status = "okay"; > +}; > + > &gpi_dma0 { > status = "okay"; > }; > @@ -316,6 +328,18 @@ touchscreen@48 { > }; > }; > > +&ipa { > + firmware-name = "qcom/sm6350/Sony/pdx213/ipa_fws.mbn"; > + > + status = "okay"; > +}; > + > +&mpss { > + firmware-name = "qcom/sm6350/Sony/pdx213/modem.mbn"; > + > + status = "okay"; > +}; [Severity: Low] Should firmware-name for adsp, cdsp, ipa, and mpss use the platform codename ("qcom/sm6350/Sony/lena/...") instead of "pdx213"? Other Sony Xperia device trees in arch/arm64/boot/dts/qcom/, including single-board files such as sm6375-sony-xperia-murray-pdx225.dts and sm8550-sony-xperia-yodo-pdx234.dts, follow the qcom/<soc>/Sony/<platform>/<file>.mbn convention standardized in commit f0a577c3a807 ("arm64: dts: qcom: sm8350: sagami: Fix remoteproc firmware path"). -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=4
