> selftests/bpf: Test that a drained dmabuf iterator keeps returning NULL
TL;DR: Commit message only: the test is credited to T.J. Mercier, but no From:, Co-developed-by: or Signed-off-by: names him; the review asks whether those tags should be added. > selftests/bpf: Test that a drained dmabuf iterator keeps returning NULL > > The BPF iterator docs in bpf_iterators.rst specify that the next > function of an open-coded iterator should keep returning NULL after it > has been returned once. > Add a subtest that checks this for the dmabuf iterator. It drains an > iterator, calls bpf_iter_dmabuf_next() once more and checks that the > result is NULL. The dma-bufs the test creates keep the list from being > empty, so an iterator that starts over would return one of them. > The existing open_coded subtest uses bpf_for_each(), which stops at the > first NULL and never calls next() on a drained iterator. > The selftest was originally posted by T.J. Mercier in the v1 thread: > Link: > https://lore.kernel.org/bpf/CABdmKX09vLG4U-7FwF-vm_iTy1AjGUPXka08KhWE+qJ0J=x...@mail.gmail.com/ > Signed-off-by: Kang Chen <[email protected]> The changelog says the selftest was originally posted by T.J. Mercier, but the only trailer is the submitter's Signed-off-by. Nothing names the original author: there is no From:, no Co-developed-by: with a matching Signed-off-by:, and no Suggested-by:. Documentation/process/submitting-patches.rst says Co-developed-by: is used to give attribution to co-authors, and that every Co-developed-by: must be immediately followed by a Signed-off-by: of the associated co-author. Should this carry Co-developed-by: and Signed-off-by: tags from T.J. Mercier (or have him as the From: author), depending on what he agreed to in the v1 thread? --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/43356758506
