Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] drm/msm: mdss: missing qcom,sm7250 UBWC config breaks msm_mdss_init() --
commit 9c80774ba784ea5c8dce29db13d653c875106e5d Author: Ishu Brar <[email protected]> drm/msm: mdss: Add SM7250 support This commit adds the qcom,sm7250-mdss compatible entry to mdss_dt_match. > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index 259d362475c81..8097e8f9144e4 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -563,6 +563,7 @@ static const struct of_device_id mdss_dt_match[] = { > { .compatible = "qcom,sm6350-mdss", .data = &data_76k8 }, > { .compatible = "qcom,sm6375-mdss", .data = &data_76k8 }, > { .compatible = "qcom,sm7150-mdss", .data = &data_76k8 }, > + { .compatible = "qcom,sm7250-mdss", .data = &data_76k8 }, [Severity: High] Does qcom_ubwc_configs[] in drivers/soc/qcom/ubwc_config.c also need an entry for "qcom,sm7250"? Both msm_mdss_init() (called from mdss_probe()) and dpu_kms_hw_init() call qcom_ubwc_config_get_data() and fail when it returns an error. Because qcom_ubwc_configs[] has no "qcom,sm7250" match, qcom_ubwc_config_get_data() returns ERR_PTR(-EINVAL), so MDSS and DPU probe on SM7250 will always fail. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=6
