> -----邮件原件-----
> 发件人: Krzysztof Kozlowski <[email protected]>
> 发送时间: 2026年11月13日 18:39
> 收件人: Luo Liu <[email protected]>
> 抄送: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; Wuyi Shen (沈武义) <[email protected]>;
> cix-kernel-upstream <[email protected]>
> 主题: Re: [PATCH 2/2] drm/cix: add Sky1 DisplayPort transmitter driver
>
> EXTERNAL EMAIL
>
> On Mon, Nov 09, 2026 at 06:30:10PM +0800, Luo Liu wrote:
> > diff --git a/drivers/gpu/drm/cix/dptx/Kconfig
> > b/drivers/gpu/drm/cix/dptx/Kconfig
> > new file mode 100644
> > index 000000000000..0b099f7d2ed5
> > --- /dev/null
> > +++ b/drivers/gpu/drm/cix/dptx/Kconfig
> > @@ -0,0 +1,16 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +
> > +config DRM_CIX_DP
> > + tristate "Cix DisplayPort Controller Driver"
>
> Missing ARCH dependency, look at other examples.
I will add depends on ARCH_CIX || COMPILE_TEST at next version
>
> > + depends on COMMON_CLK && DRM && OF
> > + depends on GENERIC_PHY
> > + select DRM_KMS_HELPER
> > + select DRM_DISPLAY_HELPER
> > + select DRM_DISPLAY_DP_HELPER
> > + help
> > + DRM/KMS driver for the Cix DisplayPort controller. It implements
> > + the standard DRM bridge interface and drives an external
> > + DisplayPort PHY through the generic PHY framework.
> > +
> > + To compile this driver as a module, choose M here: the module will
> > + be called cix-dptx.
>
> ...
>
> > +static struct platform_driver cix_dp_driver = {
> > + .probe = cix_dptx_probe,
> > + .remove = cix_dptx_remove,
> > + .shutdown = cix_dptx_shutdown,
> > + .driver = {
> > + .name = "cix-dptx",
> > + .of_match_table = cix_dptx_dt_ids,
> > + .pm = pm_sleep_ptr(&cix_dptx_pm_ops),
> > + },
> > +};
> > +
> > +module_platform_driver(cix_dp_driver);
> > +
> > +MODULE_AUTHOR("Luo Liu <[email protected]>");
> MODULE_AUTHOR("Wuyi
> > +Shen <[email protected]>"); MODULE_DESCRIPTION("Cix DisplayPort
> > +Controller Driver"); MODULE_LICENSE("GPL");
> > +MODULE_ALIAS("platform:cix-dptx");
>
> Drop alias, it's not a substitute for incomplete ID tables.
OK , I will remove it at next version
Thank you very much again
Best regards,
Luo
>
> Best regards,
> Krzysztof
本邮件及其附件包含CIX公司的保密信息,受法律保护,仅供本邮件指定的收件人查阅。严禁任何未经授权的使用、传播、分发或复制本邮件及其任何内容。此限制适用于指定收件人以外的所有人员,包括未经明确授权处理此类信息的CIX公司员工或代理人。若您误收本邮件,请立即通知发件人,并永久删除邮件及所有附件。互联网传输无法保证及时性、安全性、完整性和无病毒性,CIX公司对任何传输错误或遗漏概不承担责任。