The tegra_channel_get_remote_source_subdev() helper walks up the chain to the initial source. It blindly uses pad 0, assuming it will always be the remote source pad. This may not be the case for more complex multipad devices — for example, the mt9m114 camera sensor with a built-in IFP, where the source pad is 1. Switch to media_entity_remote_source_pad_unique() to specifically retrieve the remote source pad.
Signed-off-by: Svyatoslav Ryhel <[email protected]> --- drivers/media/platform/nvidia/tegra-video/vi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/nvidia/tegra-video/vi.c b/drivers/media/platform/nvidia/tegra-video/vi.c index 12eaa89304e84..a96ef26af89eb 100644 --- a/drivers/media/platform/nvidia/tegra-video/vi.c +++ b/drivers/media/platform/nvidia/tegra-video/vi.c @@ -187,9 +187,11 @@ tegra_channel_get_remote_source_subdev(struct tegra_vi_channel *chan) if (!subdev) return NULL; + entity = &subdev->entity; + pad = &subdev->entity.pads[0]; while (!(pad->flags & MEDIA_PAD_FL_SOURCE)) { - pad = media_pad_remote_pad_first(pad); + pad = media_entity_remote_source_pad_unique(entity); if (!pad || !is_media_entity_v4l2_subdev(pad->entity)) break; entity = pad->entity; -- 2.53.0
