The inner do/while loops currently execute once for a zero-page
insertion or removal, touching a PTE and changing its count. Return
before the loops so empty requests become no-ops, including empty tiled
requests that must not divide by a zero tile stride.

Fixes: 8c8f1c958ab5 ("gma500: introduce the GTT and MMU handling logic")
Signed-off-by: Gabriel Gama <[email protected]>
---
diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c
index 
34ae0f125b83380b735ae454c775775cd74d0f62..6815b48f00d3b1bacf4a1bb492a5205cdc58e7e8
 100644
--- a/drivers/gpu/drm/gma500/mmu.c
+++ b/drivers/gpu/drm/gma500/mmu.c
@@ -534,6 +534,9 @@
        unsigned long next;
        unsigned long f_address = address;
 
+       if (!num_pages)
+               return;
+
        down_read(&pd->driver->sem);
 
        addr = address;
@@ -578,6 +581,9 @@
        unsigned long row_add;
        unsigned long f_address = address;
 
+       if (!num_pages)
+               return;
+
        if (hw_tile_stride)
                rows = num_pages / desired_tile_stride;
        else
@@ -631,6 +637,9 @@
        unsigned long next;
        unsigned long f_address = address;
        int ret = -ENOMEM;
+
+       if (!num_pages)
+               return 0;
 
        down_read(&pd->driver->sem);
 
@@ -683,6 +692,9 @@
        unsigned long f_address = address;
        int ret = -ENOMEM;
 
+       if (!num_pages)
+               return 0;
+
        if (hw_tile_stride) {
                if (num_pages % desired_tile_stride != 0)
                        return -EINVAL;

Reply via email to