Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] drm/i915/vrr: use of handle instead of real name in Signed-off-by trailer --
commit a171d275708d23dc260c42db008a450a9d345462 Author: ElXreno <[email protected]> > drm/i915/vrr: Fix the pixel clock overflow in the vmax computation > > intel_vrr_compute_vmax() multiplies crtc_clock, which is in kHz, by > 1000 in a signed int. A 3840x2400@240 timing has a 2342.4 MHz pixel > clock, so the product overflows, the quotient turns negative and vmax > is clamped to crtc_vtotal. vmin then equals vmax and VRR is never > enabled for the mode, although it is within the range of the panel. > > Do the multiplication in 64 bits. > > No Fixes tag: intel_vrr_compute_vmax() is only called for a mode > within the VRR range, such a pixel clock needs the joiner, and > intel_vrr_compute_config() takes joined modes out of the range so > far. > > Signed-off-by: ElXreno <[email protected]> [Severity: High] Could the Author and Signed-off-by lines be updated to use a real full name rather than a handle? Documentation/process/submitting-patches.rst requires a known identity rather than a pseudonym or single-word username for the Developer Certificate of Origin. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
