These fix what happens to VM_BIND jobs, queues and entities when the file or a VM_BIND queue is closed while jobs are still pending.
Patch 1 makes a VM_BIND job that the scheduler kills before it runs apply its queued unmaps before it drops the references that keep the unmapped pages alive, release its BO pins, and mark the VM unusable, as the VM no longer matches its pgtables. Patch 2 destroys the VM_BIND entity when its queue is closed, instead of on the final put, which can come after the VM's scheduler has been torn down. Patch 3 puts the queue last when a job is freed, as the queue may hold the last reference to the VM. Changes in v3: - Patch 1: only apply the queued ops of a job that the scheduler frees after killing it, once its dependencies and the previous job of its entity are done. The error path of msm_ioctl_vm_bind() frees the job right away, so v2 could apply its unmaps too early and out of order (Sashiko). That path is left as it is in mainline, and the title now says which jobs the patch is about. - Patch 3: rebased on patch 1, title adjusted. Changes in v2: - New patch 1, for an issue that Sashiko reported on v1 patch 1, which that patch makes easier to hit. - Patch 2: changelog refers to patch 1. v2: https://lore.kernel.org/r/[email protected] v1: https://lore.kernel.org/r/[email protected] Jiwoo Kim (3): drm/msm: Release the pins and ops of a killed VM_BIND job drm/msm: Destroy the VM_BIND entity when its queue is closed drm/msm: Put the VM_BIND queue last when freeing a VM_BIND job drivers/gpu/drm/msm/msm_gem_vma.c | 99 +++++++++++++++++++++++---- drivers/gpu/drm/msm/msm_gpu.h | 6 ++ drivers/gpu/drm/msm/msm_submitqueue.c | 50 ++++++++++---- 3 files changed, 128 insertions(+), 27 deletions(-) base-commit: 1e59855738454b14021b64115f0090eafc7526ae -- 2.43.0
