Thank you for your contribution! Sashiko AI review found no new issues in this patch, but noticed 1 related pre-existing issue it does not introduce: - [Medium] drm/tests: bridge: memory leak of edid in drm_test_bridge_chain_init() [1] --
commit e45be11e80ff96e23882e09db24056eb896ea3a6 Author: Cristian Ciocaltea <[email protected]> drm/tests: bridge: Set supported HDMI version This commit sets supported_hdmi_ver to HDMI_VERSION_1_4 on HDMI test bridges in the KUnit bridge tests. > diff --git a/drivers/gpu/drm/tests/drm_bridge_test.c > b/drivers/gpu/drm/tests/drm_bridge_test.c > index 15583ade84946..a445f71c31b84 100644 > --- a/drivers/gpu/drm/tests/drm_bridge_test.c > +++ b/drivers/gpu/drm/tests/drm_bridge_test.c > @@ -497,6 +497,7 @@ drm_test_bridge_chain_init(struct kunit *test, unsigned > int num_bridges, > bridge->type = DRM_MODE_CONNECTOR_HDMIA; > bridge->vendor = "LNX"; > bridge->product = "KUnit"; > + bridge->supported_hdmi_ver = HDMI_VERSION_1_4; > bridge->supported_formats = > (BIT(DRM_OUTPUT_COLOR_FORMAT_RGB444) | > > BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444) | > > BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR422) | [Severity: Medium] This problem wasn't introduced by this patch, but does drm_test_bridge_chain_init() leak edid [1] when has_hdmi is true? drivers/gpu/drm/tests/drm_bridge_test.c:drm_test_bridge_chain_init() { ... scoped_guard(mutex, &drm->mode_config.mutex) { edid = drm_edid_alloc(test_edid_hdmi_1080p_rgb_yuv_4k_yuv420_dc_max_200mhz, ARRAY_SIZE(test_edid_hdmi_1080p_rgb_yuv_4k_yuv420_dc_max_200mhz)); if (!edid) return ERR_PTR(-EINVAL); drm_edid_connector_update(priv->connector, edid); KUNIT_ASSERT_GT(test, drm_edid_connector_add_modes(priv->connector), 0); ret = priv->connector->funcs->fill_modes(priv->connector, 4096, 4096); } ... } drm_edid_connector_update() copies the EDID data into a connector property blob without taking ownership of edid, and drm_edid_free() is never called before returning. [1] https://sashiko.dev/#/bug/linux-cc41077e-4212-413a-a83b-7a6487bad187 -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=23
