Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] remoteproc: qcom_wcnss: pass &wcnss->mem_reloc pointer to qcom_mdt_pas_load() --
commit bbce99972cf43472e018d3d98b3d4c3750b4305e Author: Mukesh Ojha <[email protected]> remoteproc: qcom_wcnss: migrate to qcom_mdt_pas_load() and qcom_pas_prepare_and_auth_reset() This commit allocates a PAS context in wcnss_probe() and migrates wcnss_load() and wcnss_start() to qcom_mdt_pas_load() and qcom_pas_prepare_and_auth_reset(). > diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c > index c856a92af43ce..750395922ef63 100644 > --- a/drivers/remoteproc/qcom_wcnss.c > +++ b/drivers/remoteproc/qcom_wcnss.c > @@ -96,6 +96,7 @@ struct qcom_wcnss { > phys_addr_t mem_reloc; > void __iomem *mem_region; > size_t mem_size; > + struct qcom_pas_context *pas_ctx; > > struct qcom_rproc_subdev smd_subdev; > struct qcom_sysmon *sysmon; > @@ -157,9 +158,7 @@ static int wcnss_load(struct rproc *rproc, const struct > firmware *fw) > struct qcom_wcnss *wcnss = rproc->priv; > int ret; > > - ret = qcom_mdt_load(wcnss->dev, fw, rproc->firmware, WCNSS_PAS_ID, > - (__force void *)wcnss->mem_region, wcnss->mem_phys, > - wcnss->mem_size, &wcnss->mem_reloc); > + ret = qcom_mdt_pas_load(wcnss->pas_ctx, fw, rproc->firmware, > wcnss->mem_reloc); [Severity: High] Should the fourth argument to qcom_mdt_pas_load() be &wcnss->mem_reloc instead of wcnss->mem_reloc? qcom_mdt_pas_load() takes a phys_addr_t * for reloc_base, so passing wcnss->mem_reloc by value fails to build with -Werror=int-conversion (or dereferences the physical address as a pointer in qcom_mdt_load_no_init()). -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
