Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] dt-bindings: display: panel: missing panel-specific compatible string --
commit 7841ad6a366c1d68596c6fd31270d044bd848d2b Author: Venkat Yadlapati <[email protected]> dt-bindings: display: panel: Add Ilitek ILI97680A This commit adds a Devicetree binding schema and MAINTAINERS entry for the Ilitek ILI97680A-based 1264x2780 BOE AMOLED panel found in the Motorola Signature. > diff --git > a/Documentation/devicetree/bindings/display/panel/ilitek,ili97680a.yaml > b/Documentation/devicetree/bindings/display/panel/ilitek,ili97680a.yaml > new file mode 100644 > index 0000000000000..f3323fbd587f6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili97680a.yaml > @@ -0,0 +1,70 @@ [ ... ] > +description: > + 1264x2780 BOE AMOLED panel driven by an Ilitek ILI97680A controller over > + four MIPI DSI lanes in command mode with DSC 1.2 compression, as found in > + the Motorola Signature. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: ilitek,ili97680a [Severity: Medium] Should compatible require a specific panel compatible string (such as boe,<panel-model> or motorola,signature-panel) followed by ilitek,ili97680a as a fallback? ILI97680A is the display controller IC driving a specific 1264x2780 BOE AMOLED panel. Other panels built around the same controller can have different resolutions, dimensions, DSC settings, and initialization sequences, so using the bare controller compatible alone prevents distinguishing them in future Devicetrees without breaking ABI compatibility. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
