Thank you for your contribution! Sashiko AI review found 3 potential issues to consider: - [Medium] dt-bindings: display: panel: novatek,nt36525: inverted RESX reset-gpios polarity - [Medium] dt-bindings: display: panel: novatek,nt36525: missing vpos-supply and vneg-supply properties - [Medium] dt-bindings: display: novatek,nt36525: additionalProperties blocks backlight --
commit ff4d190494305111a5c1b07276dbb75205cedb54 Author: Adil Hüsrev Tepe <[email protected]> dt-bindings: display: panel: add Novatek NT36525 This commit adds a Device Tree binding schema for MIPI-DSI video-mode panels based on the Novatek NT36525 controller. > diff --git > a/Documentation/devicetree/bindings/display/panel/novatek,nt36525.yaml > b/Documentation/devicetree/bindings/display/panel/novatek,nt36525.yaml > new file mode 100644 > index 0000000000000..5c6e7cce06411 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36525.yaml > @@ -0,0 +1,71 @@ [ ... ] > +description: > + A MIPI-DSI video-mode panel driven by a Novatek NT36525 controller, > + 720x1480. The first compatible string names the specific panel as fitted > + in a device; the second is the NT36525 controller it is based on. The > + panel reset (RESX) is active high in the Samsung Galaxy XCover5 bring-up > + sequence. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - samsung,xcover5-nt36525 > + - const: novatek,nt36525 > + > + reg: > + maxItems: 1 > + description: DSI virtual channel > + > + reset-gpios: > + maxItems: 1 > + > + vdd-supply: > + description: panel power supply [Severity: Medium] Should this binding also declare vpos-supply and vneg-supply? In commit "drm/panel: add Novatek NT36525 panel driver", nt36525_probe() requests three separate regulators ("vdd", "vpos", and "vneg") and nt36525_prepare() sequences all three rails. Without vpos-supply and vneg-supply in the schema, device tree nodes that provide the positive and negative analog bias supplies consumed by the driver will fail dtbs_check validation. > + > + port: true > + > +required: > + - compatible > + - reg > + - reset-gpios > + - vdd-supply > + - port > + > +additionalProperties: false [Severity: Medium] Does additionalProperties: false reject the backlight property and other common properties inherited from panel-common.yaml#? Because additionalProperties: false forbids any property from a referenced schema that is not re-listed locally, standard properties from panel-common.yaml# such as backlight cause dtbs_check errors, even though nt36525_probe() in commit "drm/panel: add Novatek NT36525 panel driver" parses backlight via drm_panel_of_backlight(). Using unevaluatedProperties: false instead allows the inherited properties from panel-common.yaml# and avoids needing to duplicate reset-gpios and port. > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "samsung,xcover5-nt36525", "novatek,nt36525"; > + reg = <0>; > + reset-gpios = <&gpa0 0 GPIO_ACTIVE_HIGH>; [Severity: Medium] Is the reset-gpios polarity inverted in the description and example? Under panel-common.yaml#, reset-gpios is logically active when asserting reset. The RESX pin on the NT36525 is physically active-low (asserted low to reset and driven high to release reset, as shown by the 1-0-1 pulse in nt36525_prepare() in commit "drm/panel: add Novatek NT36525 panel driver"), so it should be described as active-low and use GPIO_ACTIVE_LOW. -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
