From: Ville Syrjälä <[email protected]>

The current property rejection debug claims that no properties
can be changed during async flips, which is simply not true.
Reword the message to indicate that the attempted property change
is unsupported. Also include the KMS object type/ID/name in the
debug message to help the person reading the logs.

Signed-off-by: Ville Syrjälä <[email protected]>
---
 drivers/gpu/drm/drm_atomic_uapi.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_atomic_uapi.c 
b/drivers/gpu/drm/drm_atomic_uapi.c
index 2ea03b4b0be9..aad71d3e2105 100644
--- a/drivers/gpu/drm/drm_atomic_uapi.c
+++ b/drivers/gpu/drm/drm_atomic_uapi.c
@@ -1227,7 +1227,8 @@ int drm_atomic_set_property(struct drm_atomic_commit 
*state,
 
                        if (old_val != prop_value) {
                                drm_dbg_atomic(prop->dev,
-                                              "[PROP:%d:%s] No prop can be 
changed during async flip\n",
+                                              "[CONNECTOR:%d:%s][PROP:%d:%s] 
Unsupported property change during async flip\n",
+                                              connector->base.id, 
connector->name,
                                               prop->base.id, prop->name);
                                ret = -EINVAL;
                                break;
@@ -1257,7 +1258,8 @@ int drm_atomic_set_property(struct drm_atomic_commit 
*state,
 
                        if (old_val != prop_value) {
                                drm_dbg_atomic(prop->dev,
-                                              "[PROP:%d:%s] No prop can be 
changed during async flip\n",
+                                              "[CRTC:%d:%s][PROP:%d:%s] 
Unsupported property change during async flip\n",
+                                              crtc->base.id, crtc->name,
                                               prop->base.id, prop->name);
                                ret = -EINVAL;
                                break;
@@ -1293,7 +1295,8 @@ int drm_atomic_set_property(struct drm_atomic_commit 
*state,
                            prop != config->prop_in_fence_fd &&
                            prop != config->prop_fb_damage_clips) {
                                drm_dbg_atomic(prop->dev,
-                                              "[PROP:%d:%s] No prop can be 
changed during async flip\n",
+                                              "[PLANE:%d:%s][PROP:%d:%s] 
Unsupported property change during async flip\n",
+                                              plane->base.id, plane->name,
                                               prop->base.id, prop->name);
                                ret = -EINVAL;
                                break;
-- 
2.56.0

Reply via email to