Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/panthor: unused variable csg_iface in panthor_group_create()
--

commit 71ef359cc5f25037d19672b0d70e07aa5a47adee
Author: Ketil Johnsen <[email protected]>

drm/panthor: Use a copy of suspend buffer sizes

This commit caches the regular and protected suspend buffer sizes from the
firmware CSG control interface during initialization and uses the cached
size when allocating the suspend buffer in panthor_group_create().

> diff --git a/drivers/gpu/drm/panthor/panthor_sched.c 
> b/drivers/gpu/drm/panthor/panthor_sched.c
> index ca6aa6a55661a..9c78f04d4f30a 100644
> --- a/drivers/gpu/drm/panthor/panthor_sched.c
> +++ b/drivers/gpu/drm/panthor/panthor_sched.c
> @@ -4058,7 +4058,7 @@ int panthor_group_create(struct drm_file *file,
>       struct panthor_scheduler *sched = ptdev->scheduler;
>       struct panthor_fw_csg_iface *csg_iface = 
> panthor_fw_get_csg_iface(ptdev, 0);
>       struct panthor_group *group = NULL;
> -     u32 gid, i, suspend_size;
> +     u32 gid, i;
>       int ret;
>  
>       if (group_args->pad)
> @@ -4109,8 +4109,8 @@ int panthor_group_create(struct drm_file *file,
>               goto err_put_group;
>       }
>  
> -     suspend_size = csg_iface->control->suspend_size;
> -     group->suspend_buf = panthor_fw_alloc_suspend_buf_mem(ptdev, 
> suspend_size);
> +     group->suspend_buf =
> +             panthor_fw_alloc_suspend_buf_mem(ptdev, 
> panthor_fw_suspend_size(ptdev));
>       if (IS_ERR(group->suspend_buf)) {
>               ret = PTR_ERR(group->suspend_buf);
>               group->suspend_buf = NULL;

[Severity: Low]
Does replacing csg_iface->control->suspend_size with
panthor_fw_suspend_size(ptdev) leave csg_iface unused in
panthor_group_create()?  That triggers a -Wunused-variable warning (and a
build failure with CONFIG_WERROR=y) at this point in the series, as the
csg_iface declaration is only removed in the later commit "drm/panthor:
Protm support for groups".

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=10

Reply via email to