Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/i915/dp: raw email report in changelog, sign-off mismatch, and Fixes tag --
commit 4c3a78dc876392e84ec307e2257c7451d9a82be2 Author: Frederik Schwan <[email protected]> > i915: UHBR training fails with TB5 dock after 1fd440de4e02; source FFE update > skipped? > > Hi everyone, > I just upgraded my system to 7.3.x and found a regression with my > notebook/dock setup. > 3x 4k displays are hooked to the dock, 2 by DP and one through USB-C (I guess > that DP-alt mode then). > > Until 7.2 all displays worked. With 7.3 all displays work until kernel > switches from fbdev (?) after > which the 2 DP displays have no signal anymore but the USB-C one still works. > > Bisect: > > # bad: [c03c1a14507dfaf8b856c2608f9ac216021fc222] Linux 7.3 > # good: [8d3ae59288f1e7d58d76558a6ee96d533bc5019f] Linux 7.2 > git bisect start 'v7.3' 'v7.2' '--' 'drivers/gpu/drm/i915/display' > 'drivers/gpu/drm/display' > # good: [bbf51a67d1fe895f3d27402d2560259a619b6dba] drm/i915/dp_link_caps: Use > max common lane count from link_caps > git bisect good bbf51a67d1fe895f3d27402d2560259a619b6dba > # good: [d6a1bc7c9b4ce71674a633242251d8a804ced82d] drm/i915: Throw away the > BIOS fb if has the wrong depth/bpp > git bisect good d6a1bc7c9b4ce71674a633242251d8a804ced82d > # bad: [f0cabcc880aba3f05ca59d735f6d166b7fceca80] drm/i915/fbc: No surface > size restrictions from LNL onwards > git bisect bad f0cabcc880aba3f05ca59d735f6d166b7fceca80 > # good: [b0b6d44646dc7750df4f052d17688fb7e7569a74] drm/dp_tunnel: Add UHBR > tunneling support > git bisect good b0b6d44646dc7750df4f052d17688fb7e7569a74 > # bad: [662560bad9be29c3e1a2668806392d2ed9a743d6] drm/i915/bw: Fix spelling > mistake "threshod" -> "threshold" > git bisect bad 662560bad9be29c3e1a2668806392d2ed9a743d6 > # good: [47fff2b1749e9ba5dfab7528960555cc865360b5] drm/i915/dp: Disable UHBR > link configs with 1/2 lanes > git bisect good 47fff2b1749e9ba5dfab7528960555cc865360b5 > # bad: [8b9bc7786adef4e2df3a23293c0682efac6dcc83] drm/i915/dram: Interpret > 0xF populated-channel count as 16 > git bisect bad 8b9bc7786adef4e2df3a23293c0682efac6dcc83 > # bad: [1fd440de4e02efab97874bbda0a4daf59d228fa3] drm/i915/dp_tunnel: Add > UHBR tunneling support > git bisect bad 1fd440de4e02efab97874bbda0a4daf59d228fa3 > # first 'bad' commit: [1fd440de4e02efab97874bbda0a4daf59d228fa3] > drm/i915/dp_tunnel: Add UHBR tunneling support > > I collected logs as well with `drm.debug=0x10e log_buf_len=32M > thunderbolt.dyndbg=+p`: > > good: v7.2-rc1-263-gb0b6d44646dc.log > bad: v7.2-rc1-268-g1fd440de4e02.log > patched: patched.log > > #regzbot introduced: 1fd440de4e02efab97874bbda0a4daf59d228fa3 > #regzbot title: i915: UHBR training fails through TB5 dock when source FFE > updates are skipped > > I was desperate and thought I'd give it a quick try with help of Codex which > ended in a rabbit whole of DP protocol investigation for me :). > We came up with a patch which I tested successfully. > > I've attached the patch and the "report" codex created in case you're > interested. > > Best regards, > Frederik > > UHBR link training uses intra-hop AUX replies at the DPRX address even > when LTTPRs are present. However, intel_dp_set_signal_levels() only > programs the source transmitter when intel_dp_phy_is_downstream_of_source() > identifies the receiver being trained as directly downstream of it. > With LTTPRs present, this check rejects DP_PHY_DPRX. > > As a result, UHBR training updates the requested FFE presets in the DPCD > training set but does not apply them to the source PHY. This causes > UHBR20 and UHBR10 training failures on a Meteor Lake system connected to > a ThinkPad Thunderbolt 5 Smart Dock 7500. Enabling UHBR tunneling exposed > the existing assumption in the source signal-level update path. > > Always update the source signal levels during UHBR training. Preserve > the per-PHY check for 8b/10b training, which trains downstream receivers > individually. > > With this change, the affected system completes four-lane UHBR20 > training, including channel equalization, interlane alignment and CDS. > > Fixes: 1fd440de4e02 ("drm/i915/dp_tunnel: Add UHBR tunneling support") > Signed-off-by: Frederik Schwan <[email protected]> > Assisted-by: Codex:gpt-6 [Severity: Low] Should the Fixes tag reference a421d8a99216 ("drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata") instead? Commit 1fd440de4e02 ("drm/i915/dp_tunnel: Add UHBR tunneling support") only enabled 128b/132b link rates over DP tunnels and exposed this issue on Thunderbolt 5 docks. The bug in intel_dp_set_signal_levels() when training 128b/132b links with LTTPRs was introduced by a421d8a99216 ("drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata"), which switched intel_dp_128b132b_lane_eq() to concurrent intra-hop AUX mode passing DP_PHY_DPRX without updating intel_dp_set_signal_levels() to program the source PHY for UHBR links, and citing 1fd440de4e02 ("drm/i915/dp_tunnel: Add UHBR tunneling support") could prevent backports to stable kernels with non-tunneled UHBR and LTTPR configurations. In addition, the subject line is phrased as a bug-report question rather than an imperative patch subject with the "drm/i915/dp:" prefix, the first half of the commit message retains the conversational email report, raw git bisect output, and regzbot directives, and the Author email address (<[email protected]>) does not match the Signed-off-by address (<[email protected]>). -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
