Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/atomic: missing Fixes trailer for drm_crtc_commit_wait()
  NULL deref fix
--

commit 433f54d3266af0158d7292f32d2620e6b84e2e85
Author: Ville Syrjälä <[email protected]>

> drm/atomic: Store the device in drm_crtc_commit
>
> drm_crtc_commit_wait() gets the device for its timeout messages from
> commit->crtc, which is NULL for the fake commit that tracks unbound
> planes and connectors. If waiting for the fake commit's hw_done ever
> times out we oops instead of printing the message.
>
> Store the device in the commit and use it for the messages instead,
> and also print the CRTC when there is one so the messages say which
> commit timed out. Document that drm_crtc_commit.crtc is NULL for the
> fake commit.
>
> Cc: Maarten Lankhorst <[email protected]>
> Signed-off-by: Ville Syrjälä <[email protected]>

[Severity: Low]
This fixes a NULL pointer dereference introduced when
drm_crtc_commit_wait() was converted from DRM_ERROR() to
drm_err(commit->crtc->dev, ...).  Should this include a Fixes: tag?

  Fixes: 6e22dc358377 ("drm: get rid of DRM_DEBUG_* log calls in drm core, 
files drm_a*.c")

-- 
Sashiko AI review · 
https://sashiko.dev/#/patchset/[email protected]?part=4

Reply via email to