On Tue, Nov 17, 2026 at 7:53 AM Konrad Dybcio <[email protected]> wrote: > > > > On 11-Nov-26 14:05, Dmitry Baryshkov wrote: > > a3xx_irq() acks every interrupt without looking at it, so a write to a > > protected register shows up only as a hangcheck timeout with no hint of > > which register was hit. Print the faulting address the way a4xx and a5xx > > already do. > > > > Signed-off-by: Dmitry Baryshkov <[email protected]> > > --- > > drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/msm/adreno/a3xx_gpu.c > > b/drivers/gpu/drm/msm/adreno/a3xx_gpu.c > > index 160d302e16a3..7e03b7305493 100644 > > --- a/drivers/gpu/drm/msm/adreno/a3xx_gpu.c > > +++ b/drivers/gpu/drm/msm/adreno/a3xx_gpu.c > > @@ -419,7 +419,14 @@ static irqreturn_t a3xx_irq(struct msm_gpu *gpu) > > status = gpu_read(gpu, REG_A3XX_RBBM_INT_0_STATUS); > > DBG("%s: %08x", gpu->name, status); > > > > - // TODO > > + if (status & A3XX_INT0_CP_REG_PROTECT_FAULT) { > > + u32 val = gpu_read(gpu, REG_A3XX_CP_PROTECT_STATUS); > > + > > + dev_err_ratelimited(gpu->dev->dev, > > + "CP | protected mode error | %s | addr=0x%8.8X | > > status=0x%8.8X\n", > > + val & (1 << 24) ? "WRITE" : "READ", > > + (val & 0xFFFFF) >> 2, val); > > I would really like BIT/GENMASK here..
Have a look at how it is done here, to keep it all tied back to register defn xml: https://patchwork.freedesktop.org/patch/768455/?series=178338&rev=1 BR, -R
