On Tue, 2026-11-17 at 20:26 +0200, Roman Vivchar via B4 Relay wrote: > From: Roman Vivchar <[email protected]> > > Commit 76255024cadb ("drm/mediatek: mtk_dsi: enable hs clock during > pre-enable") moved HS clock enablement from mtk_output_dsi_enable() > to mtk_dsi_poweron(). Later, the commit 3e191eddbdcb ("drm/mediatek: > mtk_dsi: Enable HS clock only at pre-enable") moved the call to the > mtk_dsi_bridge_atomic_pre_enable(). > > However, mtk_dsi_lane_ready() explicitly sets mtk_dsi_clk_hs_mode(dsi, 0) > so that DSI panels with MIPI_DSI_MODE_LPM can transmit initialization > commands in Low-Power mode during their prepare() callback. Enabling the > HS clock unconditionally in mtk_dsi_bridge_atomic_pre_enable() overrides > this before panel prepare() runs, causing command transmission to fail. > > Only enable the HS clock in mtk_dsi_bridge_atomic_pre_enable(), when > MIPI_DSI_MODE_LPM is not set, and restore mtk_dsi_clk_hs_mode(dsi, 1) in > mtk_output_dsi_enable(). This is a no-op for non-LPM bridges.
Reviewed-by: CK Hu <[email protected]> > > Fixes: 76255024cadb ("drm/mediatek: mtk_dsi: enable hs clock during > pre-enable") > Fixes: 3e191eddbdcb ("drm/mediatek: mtk_dsi: Enable HS clock only at > pre-enable") > Cc: [email protected] > Signed-off-by: Roman Vivchar <[email protected]> > --- > >
