On 11/18/26 15:23, Roosen Henri wrote:
Hello Helge, hello Sasha,

I have been bisecting the linux kernel for a regression, were a white
stripe occurs at the bottom of the display, when showing the bootlogo.

The bisect ended up at commit-582a89109ad9 ("fbcon: Fix KASAN slab-out-
of-bounds Read in fbcon_prepare_logo") on a v6.18.x kernel, [ Upstream
commit 94e6a058b16820e02f25e1221a4c4e713ba23550 ].

We use a custom bootlogo exactly full-screen. With your commit we get a
white bar at the bottom, which i think is about the size of the font-
height.

Our logo file has 800x480:

   file logo_clut224.ppm
   logo_clut224.ppm: Netpbm image data, size = 800 x 480, pixmap, ASCII
text

And the target framebuffer has the same 800x480 size:

   # cat /sys/class/graphics/fb0/virtual_size
   800,480

The logo does not exceed the screen size, still your patch introduces
this regression.

I'm happy to test a possible solution.

can you test this (completely untested!) patch:

diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index d7890e119dc7..2809c7a6893f 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -666,7 +666,7 @@ static void fbcon_prepare_logo(struct vc_data *vc, struct 
fb_info *info,
        logo_height = fb_prepare_logo(info, par->rotate);
        logo_lines = DIV_ROUND_UP(logo_height, vc->vc_font.height);
        logo_lines = min(logo_lines, rows);
-       logo_lines = min(logo_lines, new_rows - 1);
+       logo_lines = min(logo_lines, new_rows);
        if (logo_lines <= 0) {
                logo_lines = 0;
                logo_shown = FBCON_LOGO_DONTSHOW;

Helge

Reply via email to