Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [Medium] dt-bindings: soc: xilinx: xlnx,firmware-device-id duplicates power-domains - [Low] dt-bindings: soc: xilinx: DTS example fails dt-check-style in strict mode --
commit b6e53e2eec4c5f256b86a96092363aef4bc4fe16 Author: Gregory Williams <[email protected]> dt-bindings: soc: xilinx: Add Versal AI Engine DT binding This commit adds the Device Tree binding schema for the AMD Versal AI Engine tile array processor. > diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml > b/Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml > new file mode 100644 > index 0000000000000..6c97b5f0fb036 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml > @@ -0,0 +1,61 @@ [ ... ] > + xlnx,firmware-device-id: > + description: > + Device identifier as defined by Versal firmware interface. This value > is > + passed unchanged to firmware calls. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - xlnx,firmware-device-id > + > +additionalProperties: false [Severity: Medium] Should this binding use the standard power-domains property instead of a custom xlnx,firmware-device-id property? The value 0x18224072 in the example below is PM_DEV_AI from arch/arm64/boot/dts/xilinx/xlnx-versal-power.h, which is the Versal firmware power-domain node ID used by the xlnx,zynqmp-firmware power-domain provider (drivers/pmdomain/xilinx/zynqmp-pm-domains.c). Existing Versal drivers that need the PM_DEV_* ID for firmware calls obtain it from power-domains (for example, cqspi_of_get_pdata() in drivers/spi/spi-cadence-quadspi.c). Omitting power-domains with additionalProperties: false also prevents DT nodes from referencing the firmware power-domain provider. > + > +examples: > + - | > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + ai_engine: ai-engine@20000000000 { > + compatible = "xlnx,versal2-aieml"; > + reg = <0x200 0x00 0x01 0x00>; > + clocks = <&aclk0>; > + clock-names = "aclk0"; > + xlnx,firmware-device-id = <0x18224072>; > + }; > + }; [Severity: Low] This example triggers indent-unit-strict and unused-labels warnings under scripts/dtc/dt-check-style --mode=strict because it uses 2-space indentation instead of 4-space indentation and defines the unused label ai_engine. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=11
