Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/sched: missing kernel-doc for
  drm_sched_overwrite_scheduled_timestamp()
--

commit 4813d16b1085e58469356c4e77e1cbeb576347c5
Author: Philipp Stanner <[email protected]>

drm/sched: Fix memory ordering with dma_fence_overwrite_timestamp()

This commit replaces the manual timestamp flag check and assignment in
drm_sched_get_finished_job() with dma_fence_overwrite_timestamp() via a
new drm_sched_overwrite_scheduled_timestamp() helper.

> diff --git a/drivers/gpu/drm/scheduler/sched_main.c 
> b/drivers/gpu/drm/scheduler/sched_main.c
> index 99252674e2668..a065a6d2eb1c3 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
[ ... ]
> @@ -898,6 +899,22 @@ drm_sched_select_entity(struct drm_gpu_scheduler *sched)
>       return IS_ERR(entity) ? NULL : entity;
>  }
>  
> +/**
> + * drm_sched_overwrite_scheduled_timestamp - make timestamp more accurate
> + *
> + * Overwrites the timestamp of the provided scheduled fence with the one from
> + * the finished fence, if the scheduled fence is already signaled. Does 
> nothing
> + * otherwise.
> + */
> +static void
> +drm_sched_overwrite_scheduled_timestamp(struct dma_fence *finished,
> +                                     struct dma_fence *scheduled)
> +{
> +     ktime_t timestamp = dma_fence_timestamp(finished);
> +
> +     dma_fence_overwrite_timestamp(scheduled, timestamp);
> +}

[Severity: Low]
This kernel-doc comment omits @finished and @scheduled descriptions,
which causes scripts/kernel-doc warnings when building with W=1 or
generating documentation.

-- 
Sashiko AI review · 
https://sashiko.dev/#/patchset/[email protected]?part=3

Reply via email to