Refactor the error handling in udl_submit_urb(). Replace DRM_ERROR() macro with drm_err_ratelimited(). No functional changes.
Signed-off-by: Thomas Zimmermann <[email protected]> --- drivers/gpu/drm/udl/udl_main.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c index 1c3960974a10..821725cbebbe 100644 --- a/drivers/gpu/drm/udl/udl_main.c +++ b/drivers/gpu/drm/udl/udl_main.c @@ -331,15 +331,21 @@ int udl_submit_urb(struct udl_device *udl, struct urb *urb, size_t len) if (drm_WARN_ON_ONCE(drm, len > unode->alloc_size)) { ret = -EINVAL; - goto error; + goto err_udl_put_urb; } + urb->transfer_buffer_length = len; /* set to actual payload len */ + ret = usb_submit_urb(urb, GFP_ATOMIC); - error: if (ret) { - udl_put_urb(urb); - DRM_ERROR("usb_submit_urb error %x\n", ret); + drm_err_ratelimited(drm, "usb_submit_urb() failed with error %d\n", ret); + goto err_udl_put_urb; } + + return 0; + + err_udl_put_urb: + udl_put_urb(urb); return ret; } -- 2.56.0
