Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] dt-bindings: display: thead,th1520-dw-mipi-dsi example uses syscon property --
commit d819a2c2851c2350a4e59d7f97fa2750cf5e7ffc Author: Icenowy Zheng <[email protected]> dt-bindings: display: bridge: document TH1520 MIPI DSI controller This commit adds a Device Tree binding schema for the Synopsys DesignWare MIPI DSI host controller on the T-Head TH1520 SoC. > diff --git > a/Documentation/devicetree/bindings/display/bridge/thead,th1520-dw-mipi-dsi.yaml > > b/Documentation/devicetree/bindings/display/bridge/thead,th1520-dw-mipi-dsi.yaml > new file mode 100644 > index 0000000000000..4d6452a027348 > --- /dev/null > +++ > b/Documentation/devicetree/bindings/display/bridge/thead,th1520-dw-mipi-dsi.yaml > @@ -0,0 +1,102 @@ [ ... ] > + thead,vo-syscon: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the VO_SUBSYS system controller. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - resets > + - reset-names > + - interrupts > + - thead,vo-syscon > + - ports > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/thead,th1520-clk-ap.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/reset/thead,th1520-reset.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + dsi0: dsi@ffef500000 { > + compatible = "thead,th1520-dw-mipi-dsi"; > + reg = <0xff 0xef500000 0x0 0x1000>; > + interrupts = <119 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk_vo CLK_MIPI_DSI0_PCLK>, > + <&clk_vo CLK_MIPI_DSI0_CFG>, > + <&clk_vo CLK_MIPI_DSI0_REFCLK>, > + <&clk_vo CLK_MIPIDSI0_PIXCLK>; > + clock-names = "pclk", "phy_cfg", "ref", "pixel"; > + resets = <&rst TH1520_RESET_ID_DSI0_APB>; > + reset-names = "apb"; > + syscon = <&syscon_vo>; [Severity: Medium] As reported by Krzysztof Kozlowski on v1 [1], should the example use thead,vo-syscon instead of syscon? Because thead,vo-syscon is required and unevaluatedProperties is false, dt_binding_check fails on the example. In addition, the thead,vo-syscon description still does not explain what the DSI controller uses the VO_SUBSYS system controller for. [1] https://lore.kernel.org/r/20261102-spry-snobbish-hound-384cae@quoll -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
