On Thu, Nov 19, 2026 at 10:30 AM Mario Limonciello <[email protected]> wrote: > > > > On 11/11/26 10:43, Mario Limonciello wrote: > > amdgpu needs to know the bus number the platform assigned a device to > > be able to match firmware images against the right device. > > > > This was previously adjusted to be a soft filter due to > > commit 11c141672045f ("drm/amdgpu: Fix VFCT bus number matching with > > soft filter") where if everything but the number matched to take a device. > > > > This however fails when there are two identical devices. Instead save the > > initial bus number to the PCI device structure and then match that. > > > > Link: > > https://lore.kernel.org/linux-pci/[email protected]/ > > Link: > > https://lore.kernel.org/amd-gfx/[email protected]/ > > Signed-off-by: Mario Limonciello <[email protected]> > > --- > > Changes in v6: > > - Capture the firmware secondary bus number when reading bridge windows and > > ignore unconfigured values so rescans cannot replace it with runtime data > > (Sashiko). > > - No change needed in the VFCT consumers; they continue to read the cached > > value from the upstream bridge. > > - Link to v5: > > https://patch.msgid.link/[email protected] > > > > Changes in v5: > > - Record the firmware secondary bus number only on the bridge struct > > pci_dev, > > guard it with a validity bit, and keep it across rescans (Bjorn, Lijo). > > - Drop pci_bus::number_initial and have amdgpu/radeon read the saved bridge > > number when matching VFCT entries. > > > > Changes in v4: > > - Retain secondary bus bus number for a bridge across rescans, and the > > child bus is initialized > > from it during allocation, before registration callbacks run. (Sashiko) > > - Rename variable to clarify it's for bridges (Lijo) > > - Link to v3: > > https://patch.msgid.link/[email protected] > > > > Changes in v3: > > - Preserve the firmware bus number across bridge renumbering, capturing the > > secondary bus number before pci_scan_bridge_extend() clears it. > > - Adjust member name in all patches > > - Add tags > > - Link to v2: > > https://patch.msgid.link/[email protected] > > > > Changes in v2: > > - pci_alloc_dev(NULL) remains safe. > > - For buses behind a reassigned bridge, the PCI core now saves the firmware > > secondary bus > > number before clearing the bridge configuration and carries it into the > > newly allocated bus. > > Devices discovered there inherit that original number. > > - Add changes for radeon too. > > - Link to v1: > > https://patch.msgid.link/[email protected] > > > > --- > > Mario Limonciello (3): > > PCI: Cache bridge firmware secondary bus number > > drm/amdgpu: Match VFCT using initial PCI bus number > > drm/radeon: Match VFCT using initial PCI bus number > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 23 ++++++++++------------- > > drivers/gpu/drm/radeon/radeon_bios.c | 25 +++++++++++-------------- > > drivers/pci/probe.c | 16 ++++++++++++++-- > > include/linux/pci.h | 4 ++++ > > 4 files changed, 39 insertions(+), 29 deletions(-) > > --- > > base-commit: c03c1a14507dfaf8b856c2608f9ac216021fc222 > > change-id: 20261019-vfct-regression-2142fc52852a > > > > Best regards, > > -- > > Mario Limonciello <[email protected]> >
Is v6 preferred to v7? Alex
