On Thu, Nov 19, 2026 at 10:33:46AM +0100, Marek Szyprowski wrote:
> analogix_dp_set_bridge() takes a runtime PM reference at the beginning,
> but returns directly without dropping it when
> analogix_dp_init_analog_func() fails. Jump to the common error path
> instead, which drops the reference.
> 
> Fixes: 3efe2ace7f5b ("drm/bridge: analogix_dp: move basic controller init 
> into runtime PM")
> Signed-off-by: Marek Szyprowski <[email protected]>
> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c 
> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 022acb962b7c..84951413012b 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -998,7 +998,7 @@ static int analogix_dp_set_bridge(struct 
> analogix_dp_device *dp)
>  
>       ret = analogix_dp_init_analog_func(dp);

This function never fails, in fact. So this patch is just an academic
exercise.

Personally, I'd prefer you just make analogix_dp_init_analog_func()
return void, to simplify things.

Brian

>       if (ret)
> -             return ret;
> +             goto out_dp_init;
>  
>       /*
>        * According to DP spec v1.3 chap 3.5.1.2 Link Training,
> -- 
> 2.43.0
> 

Reply via email to