Use kstrtoint_from_user() to simplify kfd_debugfs_hang_hws_write().
Signed-off-by: Dmitry Antipov <[email protected]>
---
drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c | 25 ++++++++----------------
1 file changed, 8 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c
b/drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c
index 33e905d59dd9..251d9ba5af98 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c
@@ -55,31 +55,22 @@ static ssize_t kfd_debugfs_hang_hws_write(struct file *file,
const char __user *user_buf, size_t size, loff_t *ppos)
{
struct kfd_node *dev;
- char tmp[16];
uint32_t gpu_id;
- int ret = -EINVAL;
+ int ret;
+
+ ret = kstrtoint_from_user(user_buf, size, 10, &gpu_id);
+ if (ret)
+ return ret;
- memset(tmp, 0, 16);
- if (size >= 16) {
- pr_err("Invalid input for gpu id.\n");
- goto out;
- }
- if (copy_from_user(tmp, user_buf, size)) {
- ret = -EFAULT;
- goto out;
- }
- if (kstrtoint(tmp, 10, &gpu_id)) {
- pr_err("Invalid input for gpu id.\n");
- goto out;
- }
dev = kfd_device_by_id(gpu_id);
if (dev) {
kfd_debugfs_hang_hws(dev);
ret = size;
- } else
+ } else {
pr_err("Cannot find device %d.\n", gpu_id);
+ ret = -ENODEV;
+ }
-out:
return ret;
}
--
2.56.1