On Thu, Nov 19, 2026 at 03:45:58PM +0000, Karunika Choo wrote:
> Add a separate device-tree schema for Mali 5th-Gen AM GPUs.
> 
> AM_GOVERNOR controls GPU frequency. The GPU node does not accept OPP,
> cooling or GPU supply properties.
> 
> Acked-by: Boris Brezillon <[email protected]>
> Signed-off-by: Karunika Choo <[email protected]>
> ---
> v4:
> - Pick up Ack from Boris
> v3:
> - Drop the $nodename constraint from the AM GPU binding.
> - Require the arm,zena-css-mali integration compatible followed by
>   the arm,mali-gen5-am fallback.
> - Update the binding example to use the new compatible, three-cell
>   interrupt specifiers, and a single GPU clock.
> v2:
> - Move arm,mali-gen5-am support from arm,mali-valhall-csf.yaml to a
>   separate arm,mali-gen5-am.yaml schema.
> - Move the AM GPU example to the new schema and add the interrupt
>   binding headers.
> - Add the new schema to the Panthor MAINTAINERS entry.
> 
>  .../bindings/gpu/arm,mali-gen5-am.yaml        | 89 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  2 files changed, 90 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/gpu/arm,mali-gen5-am.yaml
> 
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-gen5-am.yaml 
> b/Documentation/devicetree/bindings/gpu/arm,mali-gen5-am.yaml
> new file mode 100644
> index 0000000000000..af758daec2aeb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-gen5-am.yaml
> @@ -0,0 +1,89 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpu/arm,mali-gen5-am.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARM Mali 5th Gen AM GPU
> +
> +maintainers:
> +  - Liviu Dudau <[email protected]>
> +  - Boris Brezillon <[email protected]>
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - arm,zena-css-mali
> +      - const: arm,mali-gen5-am
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    items:
> +      - description: Job interrupt
> +      - description: MMU interrupt
> +      - description: GPU interrupt
> +
> +  interrupt-names:
> +    items:
> +      - const: job
> +      - const: mmu
> +      - const: gpu
> +
> +  clocks:
> +    minItems: 1
> +    maxItems: 3
> +
> +  clock-names:
> +    minItems: 1
> +    items:
> +      - const: core
> +      - enum:
> +          - coregroup
> +          - stacks

- enum: [ coregroup, stacks ]

> +      - const: stacks
> +
> +  nvmem-cells:
> +    items:
> +      - description: bitmask of functional shader cores
> +
> +  nvmem-cell-names:
> +    items:
> +      - const: shader-present
> +
> +  power-domains:
> +    minItems: 1
> +    maxItems: 5
> +
> +  power-domain-names:
> +    minItems: 1
> +    maxItems: 5

You need to list the names

> +
> +  dma-coherent: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +  - clocks
> +

And all the flexible properties should be constrained. Since you have
only one device, I see little benefit in having wide constraints which
are not used. Each integration will add them when needed.


Best regards,
Krzysztof

Reply via email to