Hi Danilo,

Sure, I'll rename the `lock` field back to `inner` in v3.

Joel, thanks for the review!

Best,
Ivan

сб, 21 нояб. 2026 г. в 17:28, Danilo Krummrich <[email protected]>:
>
> On Thu Nov 19, 2026 at 12:18 PM CET, Ivan Tverdokhleb wrote:
> > @@ -313,16 +313,11 @@ pub struct GpuBuddyParams {
> >  ///
> >  /// # Invariants
> >  ///
> > -/// The inner [`Opaque`] contains an initialized buddy allocator.
> > +/// The `lock` field contains an initialized buddy allocator wrapped in 
> > `Opaque`.
> >  #[pin_data(PinnedDrop)]
> >  struct GpuBuddyInner {
> >      #[pin]
> > -    inner: Opaque<bindings::gpu_buddy>,
> > -
> > -    // TODO: Replace `Mutex<()>` with `Mutex<Opaque<..>>` once 
> > `Mutex::new()`
> > -    // accepts `impl PinInit<T>`.
> > -    #[pin]
> > -    lock: Mutex<()>,
> > +    lock: Mutex<Opaque<bindings::gpu_buddy>>,
>
> I think we should keep the name inner.

Reply via email to