On Thu, 24 Jan 2013, Sean Paul <seanpaul at chromium.org> wrote: > +static int ptn3460_power_up(struct ptn3460_platform_data *pd) > +{ > + int ret; > + > + if (pd->gpio_pd_n > 0) > + gpio_set_value(pd->gpio_pd_n, 1);
Hi Sean, just a random thing that caught my eye: last I checked 0 is a valid GPIO number. You can use gpio_is_valid() on the GPIO numbers. BR, Jani.