On Tue, Jul 2, 2013 at 12:43 PM, Russell King <rmk at arm.linux.org.uk> wrote:
> I will point out that relying on driver probing orders has already been
> stated by driver model people to be unsafe. This is why I will not
> adopt such a solution for my driver; it is a bad design.
Just to clarify, what you're objecting to is effectively the
following? Because it is not guaranteed in the future that the probe
order will be the same as the platform_driver_register() calls?
static int __init exynos_drm_init(void)
{
ret = platform_driver_register(&hdmi_driver);
if (ret < 0)
goto out_hdmi;
ret = platform_driver_register(&mixer_driver);
if (ret < 0)
goto out_mixer;
ret = platform_driver_register(&exynos_drm_common_hdmi_driver);
if (ret < 0)
goto out_common_hdmi;
ret = platform_driver_register(&exynos_drm_platform_driver);
if (ret < 0)
goto out_drm;
(exynos_drm_platform_driver is the driver that creates the drm_device)
Thanks
Daniel
