Hi YoungJun, On 15 April 2014 11:17, YoungJun Cho <yj44.cho at samsung.com> wrote: > This patch adds common part of dsi node. > > Signed-off-by: YoungJun Cho <yj44.cho at samsung.com> > Signed-off-by: Inki Dae <inki.dae at samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com> > --- > arch/arm/boot/dts/exynos5420.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi > b/arch/arm/boot/dts/exynos5420.dtsi > index f0184c7..aa2350a 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -422,6 +422,20 @@ > #phy-cells = <1>; > }; > > + dsi at 14500000 { > + compatible = "samsung,exynos5420-mipi-dsi"; > + reg = <0x14500000 0x10000>; > + interrupts = <0 82 0>; > + samsung,power-domain = <&disp_pd>; > + phys = <&mipi_phy 1>; > + phy-names = "dsim"; > + clocks = <&clock 411>, <&clock 146>;
Please use macros instead of numbers. > + clock-names = "bus_clk", "pll_clk"; > + status = "disabled"; nit: Move this to the end for readability. -- With warm regards, Sachin