Brian Paul wrote:
> 
> Jens Owen wrote:
> >
> > Jens Owen wrote:
> >
> > > It looks like a new field was recently added to the GLXContextRec
> > > xc/lib/GL/glx/glxclient.h:407
> > >
> > >         GLXDrawable currentReadable;
> 
> I added that last summer when I was implementing the GLX_SGI_make_current_read
> extension (glXMakeCurrentReadSGI() funcion).  Keith discovered months ago
> that adding the new field broke backward compatibility.  I told him that he
> could remove the field (and replace currentReadable with currentDrawable).

If I change this field (everywhere it's referenced), can you recommend a
test or two I can run to make sure I didn't break any expected
functionality?

> > I've moved this field to the end of the structure and the libGL.so
> > compatability issue appears to be fixed.
> 
> Hmmm, that might be good enough, but I'm not 100% certain.

I'm worried that my hack of moving it to the end could possibly end up
writing over the end of the structure allocation.  So, I'd like to try
your suggested fix of using the currentDrawable fied.

> > Wasn't this stuff recently submitted to the DRI trunk?  Maybe we can fix
> > this incompatability if this hasn't propogated out to any major distros,
> > yet.
> 
> Yes, we should really fix it ASAP.

Was this part of Mesa 4?  So this wouldn't have gone out in XFree86 4.2
or any other source releases where we care about binary compatability,
right?

--                             /\
         Jens Owen            /  \/\ _    
  [EMAIL PROTECTED]  /    \ \ \   Steamboat Springs, Colorado

_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to