On Monday 01 Jul 2002 10:10 pm, Keith Whitwell scribed numinously:"
> Michel Dänzer wrote:
> > On Mon, 2002-07-01 at 21:28, Tim Smith wrote:
> >>-   BEGIN_RING( 4 );
> >>-   OUT_RING( CP_PACKET0( RADEON_RE_TOP_LEFT, 0 ) );
> >>-   OUT_RING( (box->y1 << 16) | box->x1 );
> >>-   OUT_RING( CP_PACKET0( RADEON_RE_WIDTH_HEIGHT, 0 ) );
> >>-/* OUT_RING( ((box->y2 - 1) << 16) | (box->x2 - 1) );*/
> >>-   OUT_RING( (box->y2 << 16) | box->x2 );
> >>-   ADVANCE_RING();
> >>+        BEGIN_RING( 3 );
> >>+        OUT_RING( CP_PACKET3( RADEON_CCE_SET_SCISSORS, 1 ));
> >>+        OUT_RING( (box->y1 << 16) | box->x1 );
> >>+        OUT_RING( (box->y2 << 16) | box->x2 );
> >>+        ADVANCE_RING();
> >
> > Add Jacek's fix to use the commented out variant with -1, and it's
> > perfect! :) Or does the command account for that? Either way, great
> > job.
> >
> > Also, 'CCE' makes me think of a Rage128, the Radeon engine is usually
> > called 'CP', and the existing commands in the file are simply called
> > RADEON_CNTL_* .
>
> Michel, if you want to make those changes & commit this, that's fine with
> me.
>
> Tim, how interested are you in cvs access?

I wouldn't say no, since there are a couple of other things I'd like to poke 
at. For example the recent RH rawhide kernels have renamed the mm_struct's 
mmap_sem member to __mmap_sem, which breaks drm_bufs.h. They also leave 
instructions in the header file to call mmap_down_write() and friends 
instead. I tried that and X won't start, so I went back to being naughty 
and using __mmap_sem directly. Haven't investigated that one yet.

On the other hand the response time from you and Michel &c who do have CVS 
access is very quick, so I only need it if I become a burden to you :-)

I've made a scratch register writeback patch. I'll post it in a minute as 
it's only about 6k.

-- 
Tim Smith ([EMAIL PROTECTED])
Oh, they want meat? That is even more difficult! Meat has legs!
  -- Groo the Wanderer



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to