On Wed, 2002-07-03 at 10:06, Tim Smith wrote: > On Tuesday 02 Jul 2002 11:57 pm, Michel Dänzer scribed numinously:" > > On Tue, 2002-07-02 at 23:40, Tim Smith wrote: > > > On Monday 01 Jul 2002 10:10 pm, Keith Whitwell scribed numinously:" > > > > > > > Michel Dänzer wrote: > > > > > On Mon, 2002-07-01 at 21:28, Tim Smith wrote: > > > > >>- BEGIN_RING( 4 ); > > > > >>- OUT_RING( CP_PACKET0( RADEON_RE_TOP_LEFT, 0 ) ); > > > > >>- OUT_RING( (box->y1 << 16) | box->x1 ); > > > > >>- OUT_RING( CP_PACKET0( RADEON_RE_WIDTH_HEIGHT, 0 ) ); > > > > >>-/* OUT_RING( ((box->y2 - 1) << 16) | (box->x2 - 1) );*/ > > > > >>- OUT_RING( (box->y2 << 16) | box->x2 ); > > > > >>- ADVANCE_RING(); > > > > >>+ BEGIN_RING( 3 ); > > > > >>+ OUT_RING( CP_PACKET3( RADEON_CCE_SET_SCISSORS, 1 )); > > > > >>+ OUT_RING( (box->y1 << 16) | box->x1 ); > > > > >>+ OUT_RING( (box->y2 << 16) | box->x2 ); > > > > >>+ ADVANCE_RING(); > > > > > > > > > > Add Jacek's fix to use the commented out variant with -1, and it's > > > > > perfect! :) Or does the command account for that? Either way, great > > > > > job. > > > > > > > > > > Also, 'CCE' makes me think of a Rage128, the Radeon engine is > > > > > usually called 'CP', and the existing commands in the file are > > > > > simply called RADEON_CNTL_* . > > > > > > > > Michel, if you want to make those changes & commit this, that's fine > > > > with me. > > > > > > > > Tim, how interested are you in cvs access? > > > > > > I've made the changes (change to RADEON_CNTL_SET_SCISSORS and restore > > > the commented-out line) and committed. > > > > Welcome to the club ;), but you didn't restore the commented out line > > AFAICS. > > /* OUT_RING( ((box->y2 - 1) << 16) | (box->x2 - 1) );*/ > > That one? I put it in the state it was in prior to my change (i.e. present > put commented out) Or are you saying it should be uncommented and replace > the line after it?
Yes, in fact that's how I understood 'restored', but of course in retrospect that was just a deficiency of my English. :) Have you tried a fullscreen app now and seen the rightmost pixel column appear on the very left? -- Earthling Michel Dänzer (MrCooper)/ Debian GNU/Linux (powerpc) developer XFree86 and DRI project member / CS student, Free Software enthusiast ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek No, I will not fix your computer. http://thinkgeek.com/sf _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
